Bug#976888: snapper: Snapper does not create snapshots on systems with sysv init

[Alex]

Package: snapper
Version: 0.8.14-1
Severity: important

Dear Maintainer,
snapper seems not to ship the neccessary scripts to run on systems with
sysv init. It installs .timer units for systemd, but probably requires
cron.d scripts on systems with sysvinit, which seem to be missing.

(The attached system information is from a system that booted with systemd
and has a working snapper, but still does not have sysv scripts installed.
The problem occurs on a debian buster system with sysvinit-core
installed)

with kind regards,
Alex


-- System Information:
Debian Release: bullseye/sid
APT prefers testing
APT policy: (900, 'testing'), (800, 'unstable')
Architecture: amd64 (x86_64)
Foreign Architectures: i386

Kernel: Linux 5.8.0-3-amd64 (SMP w/16 CPU threads)
Kernel taint flags: TAINT_PROPRIETARY_MODULE, TAINT_OOT_MODULE, TAINT_UNSIGNED_MODULE
Locale: LANG=de_DE.UTF-8, LC_CTYPE=de_DE.UTF-8 (charmap=UTF-8), LANGUAGE not set
Shell: /bin/sh linked to /usr/bin/dash
Init: systemd (via /run/systemd/system)
LSM: AppArmor: enabled

Versions of packages snapper depends on:
ii libboost-thread1.71.0 1.71.0-7+b1
ii libc6 2.31-5
ii libdbus-1-3 1.12.20-1
ii libgcc-s1 10.2.0-19
ii libmount1 2.36.1-2
ii libsnapper5 0.8.14-1
ii libstdc++6 10.2.0-19

snapper recommends no packages.

snapper suggests no packages.

-- Configuration Files:
/etc/default/snapper changed [not included]

-- no debconf information

[Alex]

It looks like the regression may be introduced with the fix for Bug
#791726, in which it looks like you just removed the cron scripts
without adding another fallback for non-systemd systems.

[Plasma (David Paul)]

Dear Maintainer,

Here is a minor revision of and replacement to the patchset I submitted
yesterday. After submitting the original patchset I noticed a slight
discrepancy with the git commits I had made to record the changes made
to the packaging by the last few NMUs. I had based my commits on the
patches submitted to the BTS for the #1062906 and #1073699 bugreports
and at least in the case of #1062906 there was a minor difference
between those patches and what was actually uploaded to the archive.
I have now corrected this.


As before, this corrected patchset can be applied to the debian
packaging repository at https://salsa.debian.org/debian/snapper.git
using the git-am(1) command.

For completeness, a corrected patchset summary follows.


This patchset is composed of a few different parts.

The first part, patches v2-0001, v2-0002, and v2-0003, merely brings the
packaging repository's debian/sid branch up-to-date from its current
position at the debian/0.10.6-1 tag to the latest package version in
the Debian package archive. Patch v2-0001 brings the branch up to
version 0.10.6-1.1~exp1, patch v2-0002 up to version 0.10.6-1.1, and
patch v2-0003 up to version 0.10.6-1.2.

The second part, patches v2-1004 and v2-1005, revert two previous
commits that removed the cron scripts from the generated binary
packages. This removal was originally done as a quick fix for #791726.

The third part, patches v2-1006 and v2-1007, make two enhancements to
the cron scripts. v2-1006 adds a check early in the scripts that will
cause them to abort if the snapper binary is not found. This fixes the
original issue that prompted the filing of #791726. v2-1007 adds a
similar early check to the scripts that causes them to abort if systemd
is detected. This prevents the cron scripts running in addition to the
systemd timers on systemd-using systems.

Finally, the last part, patch v2-1008, updates the debian/changelog
file.


Again, please let me know if you have any questions or if you would
like me to make any further modifications and submit a v3 changeset.


Thanks,