Discussion:
Bug#881727: django-allauth: Invalid character reference 138 in "Last Translator" field in some .po files
(too old to reply)
Laura Arjona Reina
2017-11-14 15:20:01 UTC
Permalink
Package: django-allauth
Severity: wishlist
Tags: patch l10n upstream

Dear Maintainer,

Some of the upstream .po files, in the "Last translator" field, include a name
of translator with a bad encoded character (numeric character reference 138
instead of Å ). This produces "Tidy Validation" warning messages when building
the Debian website pages:

*** /srv/www.debian.org/www/international/l10n/po/es.fr.html
line 1008 column 412 - Warning: replacing invalid numeric character reference
138
*** /srv/www.debian.org/www/international/l10n/po/pt_PT.fr.html
line 176 column 418 - Warning: replacing invalid numeric character reference
138
*** /srv/www.debian.org/www/international/l10n/po/sv.fr.html
line 806 column 413 - Warning: replacing invalid numeric character reference
138
*** /srv/www.debian.org/www/international/l10n/po/tr.fr.html
line 845 column 412 - Warning: replacing invalid numeric character reference
138

That are sent daily or weekly to the corresponding translation coordinators in
Debian, and some Debian website team members.

I'm attaching a diff that hopefully fixes the problem, using the correct UTF-8
character.

(Meanwhile this issue is fixed, I'll disable the tidy check for the affected
languages in the Debian website build scripts).

Best regards

Laura Arjona Reina
https://wiki.debian.org/LauraArjona
Pierre-Elliott Bécue
2017-12-13 16:30:01 UTC
Permalink
Good evening,

I've included your patch in the git repository of the package [1]. It'll be
published with the next release I think.

As discussed via IRC, I put you as author of the quilt patch (and the
subsequent git commit).

Cheers,
--
Pierre-Elliott Bécue
GPG: 9AE0 4D98 6400 E3B6 7528 F493 0D44 2664 1949 74E2

[1]
https://anonscm.debian.org/cgit/python-modules/packages/django-allauth.git/commit/?id=e625f18aa267e7bd158f18ce827872276f7b0abe
Laura Arjona Reina
2018-05-02 20:10:03 UTC
Permalink
Package: django-allauth
Severity: wishlist
Tags: patch l10n upstream

Dear Maintainer,

When uploading the 0.35 version, the bug Bug#881727 reappeared again:

Some of the upstream .po files, in the "Last translator" field, include
a name of translator with a bad encoded character (numeric character
reference 138 instead of Å ). This produces "Tidy Validation" warning
messages when building the Debian website pages.
The .PO files do not include mail address for the translator with the
bad encoding, so I've requested to join the django-allauth translation
team in Transifex, with the hope of contacting Jannis Å  and request them
to fix the encoding in their profile in Transifex.

Meanwhile, I'm attaching a patch that uses the correct UTF-8 character.

Thanks!
--
Laura Arjona Reina
https://wiki.debian.org/LauraArjona
Pierre-Elliott Bécue
2018-05-04 12:10:02 UTC
Permalink
Post by Laura Arjona Reina
Package: django-allauth
Severity: wishlist
Tags: patch l10n upstream
Dear Maintainer,
Some of the upstream .po files, in the "Last translator" field, include
a name of translator with a bad encoded character (numeric character
reference 138 instead of Å ). This produces "Tidy Validation" warning
messages when building the Debian website pages.
The .PO files do not include mail address for the translator with the
bad encoding, so I've requested to join the django-allauth translation
team in Transifex, with the hope of contacting Jannis Å  and request them
to fix the encoding in their profile in Transifex.
Meanwhile, I'm attaching a patch that uses the correct UTF-8 character.
Hi,

This is very weird.

As you can see in the salsa repository, your patch is still there, and it
applied correctly (I rebased it on the new release).

As I did the upload myself, I took the .deb package I sent to the archive,
and extracted it, and placed myself in
usr/lib/python3/dist-packages/allauth/locale and ran this:

.-(.../dependencies/django-allauth/toto/usr/lib/python3/dist-packages/allauth/locale)-
`---> cat {es,pt_PT,sv,tr}/LC_MESSAGES/django.po|grep 'Jannis'
"Last-Translator: Jannis Å \n"
"Last-Translator: Jannis Å \n"
"Last-Translator: Jannis Å \n"
"Last-Translator: Jannis Å \n"

All seem fine.

As the package is also installed on my server, I also did this:

.-(13:50:00)-(~)---------------------------------------------------------(***@pimeys)-
`---> acp python-django-allauth
python-django-allauth:
Installé : 0.35.0-1~bpo9+3
Candidat : 0.35.0-1~bpo9+3
Table de version :
0.35.0-2 99
99 http://ftp.fr.debian.org/debian sid/main amd64 Packages
*** 0.35.0-1~bpo9+3 100
100 http://ftp.fr.debian.org/debian stretch-backports/main amd64 Packages
100 /var/lib/dpkg/status
.-(13:50:04)-(~)---------------------------------------------------------(***@pimeys)-
`---> cd /usr/lib/python2.7/dist-packages/allauth/locale/
.-(13:50:26)-(/usr/lib/python2.7/dist-packages/allauth/locale)-----------(***@pimeys)-
`---> cat {es,pt_PT,sv,tr}/LC_MESSAGES/django.po|grep 'Jannis'
"Last-Translator: Jannis Å \n"
"Last-Translator: Jannis Å \n"
"Last-Translator: Jannis Å \n"
"Last-Translator: Jannis Å \n"

Your patch really seems to work fine.

So, I wonder, maybe this error is triggered because the *source* actually
still contains this wrongfully encoded character? But theoretically I'm not
supposed to alter upstream's source.

Cheers,
--
Pierre-Elliott Bécue
GPG: 9AE0 4D98 6400 E3B6 7528 F493 0D44 2664 1949 74E2
It's far easier to fight for one's principles than to live up to them.
Laura Arjona Reina
2018-05-04 18:10:02 UTC
Permalink
Hello again
I have sent a Pull Request (#2017) to the upstream project fixing the
string of the translator name:
https://github.com/pennersr/django-allauth/pull/2017

Cheers
--
Laura Arjona Reina
https://wiki.debian.org/LauraArjona
Pierre-Elliott Bécue
2018-05-04 18:20:01 UTC
Permalink
Post by Laura Arjona Reina
Hello again
I have sent a Pull Request (#2017) to the upstream project fixing the
https://github.com/pennersr/django-allauth/pull/2017
Cheers
I referenced the issue I opened months ago in your MR.

You can close the bug as soon as you wish.

Sorry for all this.

Cheers !
--
PEB
Laura Arjona Reina
2018-05-04 18:10:02 UTC
Permalink
Hello Pierre-Elliot
Post by Pierre-Elliott Bécue
So, I wonder, maybe this error is triggered because the *source* actually
still contains this wrongfully encoded character? But theoretically I'm not
supposed to alter upstream's source.
Yes, that seems to be the case: I think our gen-material scripts don't
handle well the application of patches for packages with format 3.0 (quilt).
This is reported in bug #748716.

I'm excluding django-allauth from the l10n stats generation until
#748716 is solved, or upstream fixes the bad-encoded string.

Should I close this bug?

Thanks for your help
--
Laura Arjona Reina
https://wiki.debian.org/LauraArjona
Loading...