Discussion:
Bug#876896: dput: please have rsync not change permissions (-p)
Add Reply
Ansgar Burchardt
2017-09-26 18:50:01 UTC
Reply
Permalink
Package: dput
Version: 0.12.1
Severity: normal

dput 1.0.1 (and also 0.12.1) use the following rsync options (from
dput/methods/rsync.py):

--copy-links --progress --partial -zave 'ssh -x'

-a implies quite a lot:

-r: recursive; not wanted
-l: copy-symlinks-as-symlinks; not wanted, overriden by --copy-links
-p: copy permissions; not wanted, overriden by chmod
-t: times; wanted
-g, -o, -D: keep group, owner, devices/special files; not wanted

Please replace `-a` by `--times` or `-t`.

The separate `chmod` call can be replaced by `--chmod=F644` or
`--chmod=ugo=rwX`. Please also include an option to *not* affect
permissions and just use the default permissions.

I would like this to support uploading via rsync-over-ssh for the
security archive (to ssh.security.upload.debian.org). We do not want
uploads to be readable by anyone. The upload directory has a default
ACL to set the right permissions, however `rsync -p` or `chmod`
override it.

Ansgar
Ben Finney
2018-01-28 01:30:01 UTC
Reply
Permalink
Package: dput
Severity: minor
Control: block 389908 by -1
Control: block 876896 by -1
Additionally, the chmod should be optional or configurable. It fails
when the scp target account has its shell set to scponly.
The separate `chmod` call [after ‘rsync’ upload] can be replaced by
`--chmod=F644` or `--chmod=ugo=rwX`. Please also include an option
to *not* affect permissions and just use the default permissions.
The ‘dput’ command currently forces a change of file permission (a
‘chmod’ operation) when uploading via some methods. This is
undesirable in some environments.

Implement configuration options to specify:

* Whether to perform the ‘chmod’ operation (default: yes).

* What permission flags to set (default: 0o0644).
--
\ “Technology is neither good nor bad; nor is it neutral.” |
`\ —Melvin Kranzberg's First Law of Technology |
_o__) |
Ben Finney <***@debian.org>
Ben Finney
2020-01-14 02:40:01 UTC
Reply
Permalink
Control: severity 389908 minor
Control: severity 876896 minor
Post by Ben Finney
The ‘dput’ command currently forces a change of file permission (a
‘chmod’ operation) when uploading via some methods. This is
undesirable in some environments.
* Whether to perform the ‘chmod’ operation (default: yes).
* What permission flags to set (default: 0o0644).
When those features (described in bug#888631) are properly
implemented, these bugs will be straightforward to address.

The earlier bug reports (bug#389908 and bug#876896) are also
“Severity: minor”.
--
\ “I installed a skylight in my apartment. The people who live |
`\ above me are furious!” —Steven Wright |
_o__) |
Ben Finney <***@debian.org>
Loading...