On Fri, 08 Nov 2019 14:47:41 +0000, Stephan Lachnit
Post by Stephan LachnitPost by Stephen Kittyou need python3-dev in the build-dependencies instead of python3
(as-is, the package doesnât build in a clean build chroot)
build-depends-on-python-dev-with-no-arch-any
However I don't really get what the difference between python3-dev and
python3 is, the lintian tag entry doesn't really help.
Right, python3 is the interpreter only, python3-dev adds a number of files
which are necessary to build Python modules. I suspect that Piper doesnât
need python3-dev, and its meson.build could be changed to avoid that
build dependency...
Post by Stephan LachnitPost by Stephen Kittthe ratbagd dependency should be (>= 0.10-1), greater than rather
than equal, otherwise the piper package ends up too closely tied to
libratbag (0.10-2 would break the dependency, as would the
forthcoming 0.11-1); in fact switching to >= means you can even drop
the package revision, and write (>= 0.10)
What I tried to do with my initial (=0.10) was to let every 0.10 version
work, so 0.10-1 and 0.10-2, however this doesn't work. I tried to bind
piper to a specific ratbagd version because the Wiki states that ratbagd
API is not stable.
OK, to do something like that youâd depend on âratbatgd (>= 0.10), ratbagd
(<< 0.11)â. Iâm not sure thatâs the best approach: youâd end up having to
upload a new version of Piper every time a new upstream version of ratbagd
was released (e.g. 0.11 which is now in the archive).
Iâd go for a different approach: if ratbagd changes in an incompatible way,
since it doesnât provide API guarantees, then it should be in charge of
keeping track of that. Technically, that would mean that an incompatible
version of ratbagd would declare that it breaks the relevant versions of
Piper, which would ensure that users wouldnât upgrade if they have an
incompatible version of Piper.
With the latter approach, non-breaking versions of ratbagd can be uploaded
without requiring a new upload of Piper. If ratbagd breaks Piper, upstream
will release a new version of Piper anyway, which would require an upload.
Post by Stephan LachnitI uploaded a new version with the right debian version and your suggestions.
I know I have to update the git workflow, will do that in the future.
OK, thanks!
If you donât have anything left to do on the package, I can upload it for
you, and create the repository on Salsa in the debian namespace.
Regards,
Stephen