Discussion:
Bug#934271: python-tablib: newer pyyaml changes default_flow_style
Add Reply
Mathieu Trudel-Lapierre
2019-08-08 22:20:01 UTC
Reply
Permalink
Package: python-tablib
Version: 0.12.1-3
Severity: normal
Tags: patch
User: ubuntu-***@lists.ubuntu.com
Usertags: origin-ubuntu eoan ubuntu-patch

Dear Maintainer,

default_flow_style=None changed to default_flow_style=False by default
in pyyaml 5.1 [1].

I wrote the following pretty heavy-handed patch to address the situation
and maintain previous behavior, though you might want to change the tests
instead and follow the changes made upstream.

[1] https://github.com/yaml/pyyaml/issues/265


*** /tmp/tmpU9xam4/bug_body

In Ubuntu, the attached patch was applied to achieve the following:

* debian/patches/fix_pyyaml_default_flow_style.patch: Make sure all calls
to yaml.dump() include default_flow_style=None, to retain previous behavior
that is checked for in tests, unless it's already otherwise specified.


Thanks for considering the patch.


-- System Information:
Debian Release: buster/sid
APT prefers eoan
APT policy: (500, 'eoan')
Architecture: amd64 (x86_64)
Foreign Architectures: i386

Kernel: Linux 5.2.0-8-generic (SMP w/4 CPU cores)
Kernel taint flags: TAINT_PROPRIETARY_MODULE, TAINT_OOT_MODULE
Locale: LANG=en_CA.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8), LANGUAGE=en_CA:en (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)
LSM: AppArmor: enabled
Joseph Herlant
2019-08-11 19:30:01 UTC
Reply
Permalink
Control: tags ! + pending
Control: forwarded ! https://github.com/vinayak-mehta/tablib/pull/374

Hi Mathieu,

Thanks for the report and sorry for the late reply.
I've uploaded the latest version of python-tablib and included your patch.
I also forwarded your patch to upstream to hopefully get it merged for
next release: https://github.com/vinayak-mehta/tablib/pull/374

I just uploaded the new package in the ftp-master queue.

Thanks
Joseph

Loading...