Bug#1090799: RFS: wayfire/0.9.0-5 [ITA] -- 3D Wayland compositor

[EiPi Fun]

Package: wnpp
From: Don Xu <***@eipi.fun>
To: ***@bugs.debian.org
Subject: RFS: wayfire/0.9.0-5 [ITA] -- 3D Wayland compositor

Package: sponsorship-requests
Severity: normal

Dear mentors,

I am looking for a sponsor for my package "wayfire":

 * Package name     : wayfire
   Version          : 0.9.0-5
   Upstream contact : Ilia Bozhinov <***@gmail.com>
 * URL              : https://wayfire.org/
 * License          : HPND, Expat
 * Vcs              : https://salsa.debian.org/debian/wayfire
   Section          : x11

In short, it is one of the wlroots-based wayland compositor.

Specially, cause wayfire depends on wlroots 0.17 thus it will cause
problem to the migration of wlroots, sway, labwc and other packages
depending on wlroots.

I made this workaround release (based on upstream unreleased branch) to
build on 0.18 and make migration of wlroots and related packages
possible.

And I will maintain this package in the future.

Temporarily, the Vcs is in my salsa:
https://salsa.debian.org/EiPiFun/wayfire
After the ITA, I will push the changes into debian/wayfire

As the pipelines showed, this package could pass autopkgtest.
https://salsa.debian.org/EiPiFun/wayfire/-/pipelines/782534

The source builds the following binary packages:

  libwf-touch-dev - 3D Wayland compositor (wf-touch library dev files)
  libwf-utils-dev - 3D Wayland compositor (wf-utils library dev files)
  libwf-utils0t64 - 3D Wayland compositor (wf-utils library)
  wayfire - 3D Wayland compositor
  wayfire-dev - 3D Wayland compositor (development files)

To access further information about this package, please visit the
following URL:

  https://mentors.debian.net/package/wayfire/

Alternatively, you can download the package with 'dget' using this
command:

  dget -x
https://mentors.debian.net/debian/pool/main/w/wayfire/wayfire_0.9.0-5.dsc

Changes since the last upload:

 wayfire (0.9.0-5) unstable; urgency=medium
 .
   * Adopt package (Closes: #1076391)
   * Workaround release based on upstream tracker-wlroots branch:
     - This branch supports wlroots 0.18, required for transition
   * 0001_release_to_upstream_tracker_wlroots_branch.patch:
     - Rebased on 0.9.0-2, one patch from 0.9.0 to tracker-wlroots
   * Drop the old patches cause they conflict
   * debian/missing-sources:
     - Upstream uses links instead of real files
   * Update lintian-overrides
   * Recommend xdg-desktop-portal-wlr/gtk (Closes: #1050914)

Best Regards,

[Johannes Schauer Marin Rodrigues]

Hi,

thank you for wanting to maintain wayfire.

How did you assemble the CC of your bug mail? I do not see the connection of
some of the recipients with wayfire, so I'm trimming the recipient list in my
reply.

Also, for the future, when opening a bug in the Debian BTS, use the
X-Debbugs-CC pseudo-header to list further recipients of your bug. The
advantage is, that in contrast to what happened now, the bug is only sent out
*after* the BTS created a bug number for it. I now had to manually find out
the bug number for my reply.

I can sponsor you, but I have some questions.

Quoting EiPi Fun (2024-12-19 13:20:44)

Post by EiPi Fun
Specially, cause wayfire depends on wlroots 0.17 thus it will cause
problem to the migration of wlroots, sway, labwc and other packages
depending on wlroots.
I made this workaround release (based on upstream unreleased branch) to
build on 0.18 and make migration of wlroots and related packages
possible.

I already did that work. Wayfire 0.9.0-4 in unstable is using libwlroots-0.18.
What made you ignore this?

Post by EiPi Fun
And I will maintain this package in the future.

Thank you for offering your help.

Post by EiPi Fun
https://salsa.debian.org/EiPiFun/wayfire
After the ITA, I will push the changes into debian/wayfire

Your repository is not a fork of debian/wayfire but creates its own history.
Why?

Post by EiPi Fun
As the pipelines showed, this package could pass autopkgtest.
https://salsa.debian.org/EiPiFun/wayfire/-/pipelines/782534
libwf-touch-dev - 3D Wayland compositor (wf-touch library dev files)
libwf-utils-dev - 3D Wayland compositor (wf-utils library dev files)
libwf-utils0t64 - 3D Wayland compositor (wf-utils library)
wayfire - 3D Wayland compositor
wayfire-dev - 3D Wayland compositor (development files)
To access further information about this package, please visit the
https://mentors.debian.net/package/wayfire/

Instead of using mentors.debian.net, can we use salsa merge requests to work on
the package since you already have an account on salsa?

Post by EiPi Fun
Alternatively, you can download the package with 'dget' using this
dget -x
https://mentors.debian.net/debian/pool/main/w/wayfire/wayfire_0.9.0-5.dsc
wayfire (0.9.0-5) unstable; urgency=medium
.
* Adopt package (Closes: #1076391)
- This branch supports wlroots 0.18, required for transition
- Rebased on 0.9.0-2, one patch from 0.9.0 to tracker-wlroots
* Drop the old patches cause they conflict
- Upstream uses links instead of real files
* Update lintian-overrides
* Recommend xdg-desktop-portal-wlr/gtk (Closes: #1050914)

Can we split this into individual changes that we talk about via salsa merge
requests instead of changing everything at once? I have several questions
about what you documented in the changelog above, mainly about your
patch supporting wlroots 0.18 which I already have done. Why the change?

Thanks!

cheers, josch

[EiPi Fun]

On Thu, 2024-12-19 at 14:10 +0100, Johannes Schauer Marin Rodrigues

Post by Johannes Schauer Marin Rodrigues
Hi,
Also, for the future, when opening a bug in the Debian BTS, use the
X-Debbugs-CC pseudo-header to list further recipients of your bug. The
advantage is, that in contrast to what happened now, the bug is only sent out
*after* the BTS created a bug number for it. I now had to manually find out
the bug number for my reply.

Sorry for that, I am still quite new to Debian community, and I am
still ignorant about many things. I will remember about this, the X-
Debbugs-CC pseudo-header.

Post by Johannes Schauer Marin Rodrigues
Your repository is not a fork of debian/wayfire but creates its own history.
Why?
Instead of using mentors.debian.net, can we use salsa merge requests to work on
the package since you already have an account on salsa?
Can we split this into individual changes that we talk about via salsa merge
requests instead of changing everything at once? I have several questions
about what you documented in the changelog above, mainly about your
patch supporting wlroots 0.18 which I already have done. Why the change?

The main reason that I ignore the patches existing cause I am not
skillful, thus I use a stupid method to merge these patches:)

Any why I put many changes in one commit then amend them? Cause I do
not sure what I do will cause thus I amend them many times.

I will try to manage my repo better. We can talk later in salsa:)

Best regards,
EiPi Fun/Don Xu
Dec 19, 2024

[Johannes Schauer Marin Rodrigues]

Hi,

Quoting EiPi Fun (2024-12-19 14:47:25)

Post by Johannes Schauer Marin Rodrigues
Also, for the future, when opening a bug in the Debian BTS, use the
X-Debbugs-CC pseudo-header to list further recipients of your bug. The
advantage is, that in contrast to what happened now, the bug is only sent
out *after* the BTS created a bug number for it. I now had to manually find
out the bug number for my reply.

Sorry for that, I am still quite new to Debian community, and I am still
ignorant about many things. I will remember about this, the X- Debbugs-CC
pseudo-header.

no problem, that's why I'm telling you. :)

If you use the reportbug program to write bugs, then the program will create
the header for you.

Post by Johannes Schauer Marin Rodrigues
Can we split this into individual changes that we talk about via salsa
merge requests instead of changing everything at once? I have several
questions about what you documented in the changelog above, mainly about
your patch supporting wlroots 0.18 which I already have done. Why the
change?

The main reason that I ignore the patches existing cause I am not
skillful, thus I use a stupid method to merge these patches:)
Any why I put many changes in one commit then amend them? Cause I do
not sure what I do will cause thus I amend them many times.
I will try to manage my repo better. We can talk later in salsa:)

I think the best way forward would be for you to fork the repo at
https://salsa.debian.org/debian/wayfire then you clone that repo, create a new
branch and in that branch you work on your feature and then push that. This
will allow you to create a merge request against the debian/wayfire repository.

Let me know if you need any more guidance.

Thanks!

cheers, josch

[EiPi Fun]

On Thu, 2024-12-19 at 15:47 +0100, Johannes Schauer Marin Rodrigues
wrote:

Hi, Josch!

I fork my EiPiFun/wayfire and split the changes into multiple commits
And I already apply a merge request to debian/wayfire.

You can check it now!

With the help of Otto Kekäläinen:
https://salsa.debian.org/salsa-ci-team/pipeline/-/issues/406

I do not need to add missing-sources.

https://salsa.debian.org/EiPiFun/wayfire/-/commit/d6b44f1587e6606d5da4adb7daa8d65476706fbd

gbp.conf and specialized rules are all I need to process multiple
origs.

Best regards,
Don Xu/EiPi Fun

Dec 21, 2024

[EiPi Fun]

Hello, Thanks for your review!

I realize that the problem is, I do not tell build system to ignore
changes of misssing-sources (it will copy missing-sources to
subprojects) thus the second build will detect unexpectes source
changes.

It has been fixed by adding debian/source/options.
I think you can confirm that by yourself. Do not forget to remove the
moreinfo tag if you succeed later!

Best regards,
EiPi Fun/Don Xu

19 Dec, 2024