Control: tags -1 +confirmed
Andreas,
Preamble...
Thank you for taking the time to prepare this package and your contribution
to the Debian project.
The review below is for assistance. This review is offered to help package
submitters to Debian mentors inorder to improve their packages prior to
possible sponsorship into Debian. There is no obligation on behalf of the
submitter to make any alterations based upon information provided in the
review.
Review...
1. Build:
* pbuilder [1]: Good
* sbuild [2]: Good
2. Lintian [3]: Information, non blocking
Running lintian...
N:
I: webext-vimium-chromium: package-contains-documentation-outside-usr-share-
doc [usr/share/chromium/extensions/vimium/pages/action.html]
N:
N: This package ships a documentation file outside /usr/share/doc
N: Documentation files are normally installed inside /usr/share/doc.
N:
N: If this file doesn't describe the contents or purpose of the directory
it
N: is in, please consider moving this file to /usr/share/doc/ or maybe even
N: removing it. If this file does describe the contents or purpose of the
N: directory it is in, please add a lintian override.
N:
N: Visibility: info
N: Show-Always: no
N: Check: documentation
N:
N: Screen: python/egg/metadata
N: Advocates: "Scott Kitterman" <***@kitterman.com>
N: Reason: The folders XXX.dist-info/ and XXX.egg-info/ hold metadata for
N: Python modules. Those files are not documentation even though
N: some of their names carry the .txt file extension.
N:
N: Python modules can be both public and private.
N:
N: Read more in
N:
https://www.python.org/dev/peps/pep-0427/#the-dist-info-directory,
N: https://www.python.org/dev/peps/pep-0376/#id16,
N: https://www.python.org/dev/peps/pep-0610/,
N: https://www.python.org/dev/peps/pep-0639/,
N:
https://setuptools.pypa.io/en/latest/deprecated/python_eggs.html,
N: and Bug#1003913.
N:
N:
I: webext-vimium-chromium: package-contains-documentation-outside-usr-share-
doc [usr/share/chromium/extensions/vimium/pages/blank.html]
N:
I: webext-vimium-chromium: package-contains-documentation-outside-usr-share-
doc [usr/share/chromium/extensions/vimium/pages/completion_engines.html]
N:
I: webext-vimium-chromium: package-contains-documentation-outside-usr-share-
doc [usr/share/chromium/extensions/vimium/pages/exclusions.html]
N:
I: webext-vimium-chromium: package-contains-documentation-outside-usr-share-
doc [usr/share/chromium/extensions/vimium/pages/help_dialog.html]
N:
I: webext-vimium-chromium: package-contains-documentation-outside-usr-share-
doc [usr/share/chromium/extensions/vimium/pages/hud.html]
N:
I: webext-vimium-chromium: package-contains-documentation-outside-usr-share-
doc [usr/share/chromium/extensions/vimium/pages/options.html]
N:
I: webext-vimium-chromium: package-contains-documentation-outside-usr-share-
doc [usr/share/chromium/extensions/vimium/pages/reload.html]
N:
I: webext-vimium-chromium: package-contains-documentation-outside-usr-share-
doc [usr/share/chromium/extensions/vimium/pages/vomnibar.html]
N:
I: webext-vimium-chromium: package-contains-documentation-outside-usr-share-
doc [usr/share/chromium/extensions/vimium/resources/tlds.txt]
N:
I: webext-vimium-firefox: package-contains-documentation-outside-usr-share-
doc [usr/share/mozilla/extensions/{ec8030f7-c20a-464f-9b0e-
13a3a9e97384}/{d7742d87-e61d-4b78-b8a1-b469842139fa}/pages/action.html]
N:
I: webext-vimium-firefox: package-contains-documentation-outside-usr-share-
doc [usr/share/mozilla/extensions/{ec8030f7-c20a-464f-9b0e-
13a3a9e97384}/{d7742d87-e61d-4b78-b8a1-b469842139fa}/pages/blank.html]
N:
I: webext-vimium-firefox: package-contains-documentation-outside-usr-share-
doc [usr/share/mozilla/extensions/{ec8030f7-c20a-464f-9b0e-
13a3a9e97384}/{d7742d87-e61d-4b78-b8a1-
b469842139fa}/pages/completion_engines.html]
N:
I: webext-vimium-firefox: package-contains-documentation-outside-usr-share-
doc [usr/share/mozilla/extensions/{ec8030f7-c20a-464f-9b0e-
13a3a9e97384}/{d7742d87-e61d-4b78-b8a1-b469842139fa}/pages/exclusions.html]
N:
I: webext-vimium-firefox: package-contains-documentation-outside-usr-share-
doc [usr/share/mozilla/extensions/{ec8030f7-c20a-464f-9b0e-
13a3a9e97384}/{d7742d87-e61d-4b78-b8a1-b469842139fa}/pages/help_dialog.html]
N:
I: webext-vimium-firefox: package-contains-documentation-outside-usr-share-
doc [usr/share/mozilla/extensions/{ec8030f7-c20a-464f-9b0e-
13a3a9e97384}/{d7742d87-e61d-4b78-b8a1-b469842139fa}/pages/hud.html]
N:
I: webext-vimium-firefox: package-contains-documentation-outside-usr-share-
doc [usr/share/mozilla/extensions/{ec8030f7-c20a-464f-9b0e-
13a3a9e97384}/{d7742d87-e61d-4b78-b8a1-b469842139fa}/pages/options.html]
N:
I: webext-vimium-firefox: package-contains-documentation-outside-usr-share-
doc [usr/share/mozilla/extensions/{ec8030f7-c20a-464f-9b0e-
13a3a9e97384}/{d7742d87-e61d-4b78-b8a1-b469842139fa}/pages/reload.html]
N:
I: webext-vimium-firefox: package-contains-documentation-outside-usr-share-
doc [usr/share/mozilla/extensions/{ec8030f7-c20a-464f-9b0e-
13a3a9e97384}/{d7742d87-e61d-4b78-b8a1-b469842139fa}/pages/vomnibar.html]
N:
I: webext-vimium-firefox: package-contains-documentation-outside-usr-share-
doc [usr/share/mozilla/extensions/{ec8030f7-c20a-464f-9b0e-
13a3a9e97384}/{d7742d87-e61d-4b78-b8a1-b469842139fa}/resources/tlds.txt]
I: Lintian run was successful.
3. Licenses [4]: Good
4. Watch file [uscan --force-download]: Good
5. Build Twice [sudo pbuilder build --twice <package>.dsc]: Good
6. Reproducible builds [5]: Good
7. Install [No previous installs]: Good
8. Upgrade [Over previous installs if any]: N/A
Summary...
I believe vimium is ready for review/possible sponsorship. Could a Debian
Developer (DD) with available free time, please review this package and
upload if you feel it is ready and appropriate for the distribution.
A DD with interest in browsers would be an advantage for reviewing and
sponsoring this package.
Regards
Phil
[1] pbuilder:
* Command: sudo pbuilder build <PACKAGE>.dsc
* Document: https://wiki.ubuntu.com/PbuilderHowto.
* Document: https://wiki.debian.org/PbuilderTricks
[2] sbuild:
* Command: sbuild <PACKAGE>.dsc
* Document: https://wiki.kathenas.org/pmwiki.php/Kathenas/Article00000002
* Document: https://wiki.debian.org/sbuild
[3] lintian:
* Command: lintian -v -i -I -E --pedantic --profile debian (*.dsc,
*.changes, *.buildinfo). Each can throw up different results, so be thorough.
* Document: https://wiki.debian.org/Lintian
[4] lrc:
* Command: lrc
* Document: https://wiki.debian.org/CopyrightReviewTools#licenserecon
[5] reprotest
* Command: sudo reprotest --vary=-build_path,domain_host.use_sudo=1 --auto-
build <PACKAGE>.dsc -- schroot unstable-amd64-sbuild
* Document: https://wiki.kathenas.org/pmwiki.php/Kathenas/Article00000004
* Document: https://wiki.debian.org/ReproducibleBuilds/
* Document: https://wiki.debian.org/ReproducibleBuilds/Howto#Newer_method
--
"IÂ play the game for the gameâs own sake"
Arthur Conan Doyle - The Adventure of the Bruce-Partington Plans
--
Buy Me A Coffee: https://buymeacoffee.com/kathenasorg
Internet Relay Chat (IRC): kathenas
Matrix: #kathenas:matrix.org
Website: https://kathenas.org
Instagram: https://instagram.com/kathenasorg/
Threads: https://www.threads.net/@kathenasorg
--