Bug#1074059: bookworm-pu: package nodejs/18.19.0+dfsg-6~deb12u2

[Adrian Bunk]

Package: release.debian.org
Severity: normal
Tags: bookworm
User: ***@packages.debian.org
Usertags: pu
X-Debbugs-Cc: ***@debian.org, Debian Javascript Maintainers <pkg-javascript-***@alioth-lists.debian.net>, Jérémy Lal <***@melix.org>

This upload aims at fixing the failing build of 18.19.0+dfsg-6~deb12u1
on mips64el and mipsel.

The changes are:
- copy mips/flaky_tests.patch with mips64el skip/flaky from 18.19.1+dfsg-6
- add test-http2-forget-closed-streams to flaky on mips64el
- skip two failing tests on mipsel

This is based on reading the output of the build failures last night
with some testing done on amd64.

I am kinda optimistic that it will work and even in the worst case
it shouldn't make anything worse, but there is not enough time to
properly verify it on MIPS before the point release deadline.

I've just uploaded it, feel free to accept or reject it.

[Jonathan Wiltshire]

package release.debian.org
tags 1074059 = bookworm pending
thanks

Hi,

The upload referenced by this bug report has been flagged for acceptance into the proposed-updates queue for Debian bookworm.

Thanks for your contribution!

Upload details
==============

Package: nodejs
Version: 18.19.0+dfsg-6~deb12u2

Explanation: skip flaky tests for mipsel/mips64el

[Adrian Bunk]

***@coccia:~$ cat /srv/ftp-master.debian.org/queue/reject/nodejs_18.19.0+dfsg-6~deb12u2_amd64-buildd.changes.reason

nodejs_18.19.0+dfsg-6~deb12u2_amd64-buildd.changes: Refers to non-existing file 'libnode108_18.19.0+dfsg-6~deb12u2_amd64.deb'
Perhaps you need to include the file in your upload?

If the orig tarball is missing, the -sa flag for dpkg-buildpackage will be your friend.
***@coccia:~$


This might be some upload race condition where a gb will work?


cu
Adrian

[Adam D. Barratt]

Post by Adrian Bunk
master.debian.org/queue/reject/nodejs_18.19.0+dfsg-6~deb12u2_amd64-
buildd.changes.reason
nodejs_18.19.0+dfsg-6~deb12u2_amd64-buildd.changes: Refers to non-
existing file 'libnode108_18.19.0+dfsg-6~deb12u2_amd64.deb'
Perhaps you need to include the file in your upload?
If the orig tarball is missing, the -sa flag for dpkg-buildpackage will be your friend.
This might be some upload race condition where a gb will work?

It needed a little more handholding, because the same buildd picked it
up again and still had the .upload file from the first build.

All sorted now.

Regards,

Adam

[Salvatore Bonaccorso]

Hi all,

Post by Adrian Bunk
Package: release.debian.org
Severity: normal
Tags: bookworm
Usertags: pu
This upload aims at fixing the failing build of 18.19.0+dfsg-6~deb12u1
on mips64el and mipsel.
- copy mips/flaky_tests.patch with mips64el skip/flaky from 18.19.1+dfsg-6
- add test-http2-forget-closed-streams to flaky on mips64el
- skip two failing tests on mipsel
This is based on reading the output of the build failures last night
with some testing done on amd64.
I am kinda optimistic that it will work and even in the worst case
it shouldn't make anything worse, but there is not enough time to
properly verify it on MIPS before the point release deadline.
I've just uploaded it, feel free to accept or reject it.
diffstat for nodejs-18.19.0+dfsg nodejs-18.19.0+dfsg

Thanks a lot for your work Adrian. Please note that there is currently
a nodejs upload pending for releasing via a DSA, which will rebase
nodejs to 18.20.3+dfsg-1~deb12u1 so this might invalidate those
changes.

Jérémy, Aron is that something you want to have included in your
prepared update?

Regards,
Salvatore

[Jérémy Lal]

Post by Salvatore Bonaccorso
Hi all,

Post by Adrian Bunk
Package: release.debian.org
Severity: normal
Tags: bookworm
Usertags: pu
This upload aims at fixing the failing build of 18.19.0+dfsg-6~deb12u1
on mips64el and mipsel.
- copy mips/flaky_tests.patch with mips64el skip/flaky from

18.19.1+dfsg-6

Post by Adrian Bunk
- add test-http2-forget-closed-streams to flaky on mips64el
- skip two failing tests on mipsel
This is based on reading the output of the build failures last night
with some testing done on amd64.
I am kinda optimistic that it will work and even in the worst case
it shouldn't make anything worse, but there is not enough time to
properly verify it on MIPS before the point release deadline.
I've just uploaded it, feel free to accept or reject it.
diffstat for nodejs-18.19.0+dfsg nodejs-18.19.0+dfsg

Thanks a lot for your work Adrian. Please note that there is currently
a nodejs upload pending for releasing via a DSA, which will rebase
nodejs to 18.20.3+dfsg-1~deb12u1 so this might invalidate those
changes.
Jérémy, Aron is that something you want to have included in your
prepared update?

Indeed, it's applied to 18.20.3+dfsg-1~deb12u1, along with other skipped
tests.
I'll resume work on this by the end of the week.