Jonathan Wiltshire
2025-01-28 17:20:02 UTC
Reply
PermalinkSeverity: normal
Tags: bookworm
User: ***@packages.debian.org
Usertags: pu
X-Debbugs-Cc: golang-github-containers-***@packages.debian.org, team+pkg-***@tracker.debian.org, ***@tauware.de
Control: affects -1 + src:golang-github-containers-buildah
[ Reason ]
golang-github-containers-buildah in bookworm FTBFS on the buildds since unshare
became the default.
[ Impact ]
Policy violation for golang-github-containers-buildah (must build on the
autobuild network) and inability to fix any other issues since it can't be
built.
[ Tests ]
The issue is in a test anyway, which is now disabled. This is straight backport
of a patch already in sid and testing. Manual comparison of building
1.28.2+ds1-3 and +deb12u1 verifies that the build is fixed in an sbuild unshare
environment.
[ Risks ]
Low. Backports a single patch to the test suite which has been in sid for some
time.
This is effectively an NMU, package maintainers and patch author in CC - please
shout if you have any objections.
[ Checklist ]
[x] *all* changes are documented in the d/changelog
[x] I reviewed all changes and I approve them
[x] attach debdiff against the package in (old)stable
[x] the issue is verified as fixed in unstable
[ Changes ]
diff -Nru golang-github-containers-buildah-1.28.2+ds1/debian/changelog golang-github-containers-buildah-1.28.2+ds1/debian/changelog
--- golang-github-containers-buildah-1.28.2+ds1/debian/changelog 2023-04-29 20:57:39.000000000 +0100
+++ golang-github-containers-buildah-1.28.2+ds1/debian/changelog 2025-01-27 18:43:31.000000000 +0000
@@ -1,3 +1,10 @@
+golang-github-containers-buildah (1.28.2+ds1-3+deb12u1) bookworm; urgency=medium
+
+ * Backport 0005-Disable-TestDeviceFromPath.patch:
+ fix FTBFS by skipping TestDeviceFromPath (closes: #1072147)
+
+ -- Jonathan Wiltshire <***@debian.org> Mon, 27 Jan 2025 18:43:31 +0000
+
golang-github-containers-buildah (1.28.2+ds1-3) unstable; urgency=medium
* reupload
diff -Nru golang-github-containers-buildah-1.28.2+ds1/debian/patches/0005-Disable-TestDeviceFromPath.patch golang-github-containers-buildah-1.28.2+ds1/debian/patches/0005-Disable-TestDeviceFromPath.patch
--- golang-github-containers-buildah-1.28.2+ds1/debian/patches/0005-Disable-TestDeviceFromPath.patch 1970-01-01 01:00:00.000000000 +0100
+++ golang-github-containers-buildah-1.28.2+ds1/debian/patches/0005-Disable-TestDeviceFromPath.patch 2025-01-27 18:42:25.000000000 +0000
@@ -0,0 +1,21 @@
+From: Reinhard Tartler <***@tauware.de>
+Date: Wed, 10 Jul 2024 21:16:08 -0400
+Subject: Disable TestDeviceFromPath
+
+Closes: #1072147
+---
+ pkg/parse/parse_test.go | 1 +
+ 1 file changed, 1 insertion(+)
+
+diff --git a/pkg/parse/parse_test.go b/pkg/parse/parse_test.go
+index c1f8833..6acf52f 100644
+--- a/pkg/parse/parse_test.go
++++ b/pkg/parse/parse_test.go
+@@ -87,6 +87,7 @@ func TestIsValidDeviceMode(t *testing.T) {
+ }
+
+ func TestDeviceFromPath(t *testing.T) {
++ t.Skip("Test unsuitable for debian, see https://bugs.debian.org/1072147")
+ if runtime.GOOS != "linux" {
+ t.Skip("Devices is only supported on Linux")
+ }
diff -Nru golang-github-containers-buildah-1.28.2+ds1/debian/patches/series golang-github-containers-buildah-1.28.2+ds1/debian/patches/series
--- golang-github-containers-buildah-1.28.2+ds1/debian/patches/series 2023-04-29 20:57:39.000000000 +0100
+++ golang-github-containers-buildah-1.28.2+ds1/debian/patches/series 2025-01-27 18:42:25.000000000 +0000
@@ -1 +1,2 @@
manpage-fixes.patch
+0005-Disable-TestDeviceFromPath.patch