Bug#1073847: Systemd: Fails to restart after OOM

[Sam Bull]

Package: mariadb-server
Version: 1:10.11.6-0+deb12u1
Severity: important

Dear Maintainer,

After an OOM kill, the process is not restarted by systemd.

In the service file is:
Restart=on-abort

I believe this should be:
Restart=on-abnormal

The comment in the file says it doesn't use on-failure in case of config errors, which I assume is caused by an unclean exit code. on-abnormal is the same as on-failure except for unclean exit code.

-- System Information:
Debian Release: 12.5
APT prefers stable-updates
APT policy: (500, 'stable-updates'), (500, 'stable-security'), (500, 'stable')
Architecture: amd64 (x86_64)

Kernel: Linux 6.1.0-21-amd64 (SMP w/2 CPU threads; PREEMPT)
Locale: LANG=en_GB.UTF-8, LC_CTYPE=en_GB.UTF-8 (charmap=UTF-8), LANGUAGE=en_GB:en
Shell: /bin/sh linked to /usr/bin/dash
Init: systemd (via /run/systemd/system)
LSM: AppArmor: enabled

Versions of packages mariadb-server depends on:
ii adduser 3.134
ii debconf [debconf-2.0] 1.5.82
ii galera-4 26.4.13-1
ii gawk 1:5.2.1-2
ii iproute2 6.1.0-3
ii libc6 2.36-9+deb12u7
ii libdbi-perl 1.643-4
ii libpam0g 1.5.2-6+deb12u1
ii libssl3 3.0.11-1~deb12u2
ii libstdc++6 12.2.0-14
ii lsof 4.95.0-1
ii mariadb-client 1:10.11.6-0+deb12u1
ii mariadb-common 1:10.11.6-0+deb12u1
ii mariadb-server-core 1:10.11.6-0+deb12u1
ii passwd 1:4.13+dfsg1-1+b1
ii perl 5.36.0-7+deb12u1
ii procps 2:4.0.2-3
ii psmisc 23.6-1
ii rsync 3.2.7-1
ii socat 1.7.4.4-2
ii zlib1g 1:1.2.13.dfsg-1

Versions of packages mariadb-server recommends:
ii libhtml-template-perl 2.97-2
ii mariadb-plugin-provider-bzip2 1:10.11.6-0+deb12u1
ii mariadb-plugin-provider-lz4 1:10.11.6-0+deb12u1
ii mariadb-plugin-provider-lzma 1:10.11.6-0+deb12u1
ii mariadb-plugin-provider-lzo 1:10.11.6-0+deb12u1
ii mariadb-plugin-provider-snappy 1:10.11.6-0+deb12u1
ii pv 1.6.20-1

Versions of packages mariadb-server suggests:
ii mailutils [mailx] 1:3.15-4
pn mariadb-test <none>
ii netcat-openbsd 1.219-1

-- Configuration Files:
/etc/mysql/mariadb.conf.d/50-server.cnf changed [not included]

-- debconf information excluded

[Otto Kekäläinen]

Hi,

Post by Sam Bull
Package: mariadb-server
Version: 1:10.11.6-0+deb12u1
Severity: important
Dear Maintainer,
After an OOM kill, the process is not restarted by systemd.
Restart=on-abort
Restart=on-abnormal
The comment in the file says it doesn't use on-failure in case of config errors, which I assume is caused by an unclean exit code. on-abnormal is the same as on-failure except for unclean exit code.

Thanks for reporting.

In Debian we do not have any plans to deviate from upstream systemd
file. If you report this upstream (or better, send them a Pull Request
with the change) and they accept it, we could backport that to Debian.

[Marco d'Itri]

Post by Sam Bull
After an OOM kill, the process is not restarted by systemd.
Restart=on-abort
Restart=on-abnormal

You are correct: https://github.com/systemd/systemd/issues/36529 .
on-abort is rarely useful and mariadb too should probably use
on-abnormal.