Bug#1074087: bookworm-pu: package debvm/0.2.10+deb12u1

[Helmut Grohne]

Package: release.debian.org
Severity: normal
Tags: bookworm
X-Debbugs-Cc: ***@packages.debian.org
Control: affects -1 + src:debvm
User: ***@packages.debian.org
Usertags: pu

[ Reason ]

The primary reason for doing a stable upload is that login has become
non-essential in unstable. Thus the default experience of "debvm-create
&& debvm-run" which spawns an unstable vm will lack the login package
and thus result in a respawning getty. That's not a nice default
experience.

As I go through the pu process, I considered other patches that would be
reasonable to backport.
* debvm-run fails hard when TERM happens to be unset.
* debvm-create installs a broken resolv.conf for Debian stretch.
* debvm-waitssh does not correctly parse --timeout=123.

I hope you can agree to also add these targeted fixes.

[ Impact ]

The default experience of debvm will be impacted. Most of the problems
can be worked around at ease:

* login: debvm-create ... --include=login
* TERM: TERM=something debvm-run ...
* --timeout: debvm-waitssh --timeout 123

[ Tests ]

None of the relevant changes happen to be covered by automated tests
unfortunately. I have resorted performing manual tests of these changes.
All but the login change have been part of unstable for quite a while
already.

[ Risks ]

The relevant changes have relatively low risks of introducing
regressions, because the changes mostly turn failing code paths into
non-failing ones and otherwise do not affect behaviour.

[ Checklist ]
[ ] *all* changes are documented in the d/changelog
Not yet. All changes are documented in git and I intend to run
gbp dch at upload time.
[*] I reviewed all changes and I approve them
[ ] attach debdiff against the package in (old)stable
I opted for attaching a git log and hope this also works for you,
because gives more details for the targeted fixes and contains
what will end up in the debian/changelog.
[*] the issue is verified as fixed in unstable

[ Changes ]

I think this is covered by the attached git log.

[ Other info ]

If you think that none of the changes warrant a stable upload because
their severity is not sufficiently important and they can be worked
around, please close this bug tagging it wontfix. If you object to
individual fixes, I am happy to reduce the scope.

You may find my git branch at:
https://salsa.debian.org/helmutg/debvm/-/tree/debian/bookworm

Helmut

[Adam D. Barratt]

Control: tags -1 + confimred

Post by Helmut Grohne
The primary reason for doing a stable upload is that login has become
non-essential in unstable. Thus the default experience of "debvm-
create
&& debvm-run" which spawns an unstable vm will lack the login package
and thus result in a respawning getty. That's not a nice default
experience.
As I go through the pu process, I considered other patches that would be
reasonable to backport.
 * debvm-run fails hard when TERM happens to be unset.
 * debvm-create installs a broken resolv.conf for Debian stretch.
 * debvm-waitssh does not correctly parse --timeout=123.

These look OK, although

Post by Helmut Grohne
  [ ] *all* changes are documented in the d/changelog
      Not yet. All changes are documented in git and I intend to run
      gbp dch at upload time.
  [*] I reviewed all changes and I approve them
  [ ] attach debdiff against the package in (old)stable
      I opted for attaching a git log and hope this also works for
you,
      because gives more details for the targeted fixes and contains
      what will end up in the debian/changelog.

This is a little non-ideal from the review perspective, because it
means we can't actually see what the changelog looks like to confirm
that e.g. the version and distribution are correct.

I'm going to assume that you'll get them correct, so please go ahead.
Note that the window for getting uploads into 12.7 will close at some
point today.

Regards,

Adam

[Helmut Grohne]

Hi Adam,

Post by Adam D. Barratt
This is a little non-ideal from the review perspective, because it
means we can't actually see what the changelog looks like to confirm
that e.g. the version and distribution are correct.

Indeed. I shall adhere to the process next time. Uploaded and actual
.debdiff attached.

Post by Adam D. Barratt
I'm going to assume that you'll get them correct, so please go ahead.
Note that the window for getting uploads into 12.7 will close at some
point today.

I didn't have the schedule in mind and am merely lucky (or unlucky)
here. Other uploads are probably more important than this one.

Helmut

[Adam D. Barratt]

Post by Helmut Grohne
Hi Adam,

Post by Adam D. Barratt
This is a little non-ideal from the review perspective, because it
means we can't actually see what the changelog looks like to
confirm
that e.g. the version and distribution are correct.

Indeed. I shall adhere to the process next time. Uploaded and actual
.debdiff attached.

Thanks.

I can see the appeal of wanting to point to a git tree, and your
request is by no means the first time people have done that rather than
providing a debdiff.

Some people seem to really not understand why we would want to review
what's actually going to be uploaded, despite multiple discussions. :-(
There may be a middle ground somewhere, but currently reviewing
proposed changes to source packages works best for us.

Regards,

Adam

[Adam D Barratt]

package release.debian.org
tags 1074087 = bookworm pending
thanks

Hi,

The upload referenced by this bug report has been flagged for acceptance into the proposed-updates queue for Debian bookworm.

Thanks for your contribution!

Upload details
==============

Package: debvm
Version: 0.2.10+deb12u1

Explanation: debvm-create: do install login; bin/debvm-waitssh: make --timeout=N work; bin/debvm-run: allow being run in environments without TERM set; fix resolv.conf in stretch