Discussion:
Bug#1071860: fis-gtm: Searches for libgcrypt with libgcrypt-config
(too old to reply)
Andreas Metzler
2024-05-25 14:40:01 UTC
Permalink
Source: fis-gtm
Version: 7.0-005-1
Severity: important
User: ***@debian.org
Usertags: libgcrypt-config-removal
Control: block 714589 by -1

fis-gtm relies on libgcrypt-config to locate libgcrypt. libgcrypt-config
is scheduled for removal and will be dropped in libgcrypt 1.11. Please
use pkg-config/pkgconf instead.

A development snapshot of the yet-unreleased libgcrypt 1.11 is available
in experimental.

cu Andreas
Andreas Tille
2024-06-23 09:30:01 UTC
Permalink
Control: tags -1 help

Hi Andreas,

strange, it has build for me.
Control: reopen 1071860
...
FATAL: libgcrypt-config not found (LIBGCRYPT_CONFIG_SCRIPT-NOTFOUND)
[...]
I admit I currently have no time to track this down. It might make
sense to upgrade to latest upstream which might have been adapted to
work without libgcrypt-config. Tagging the bug help since I have no
capacity to work on this.

Kind regards
Andreas.
--
https://fam-tille.de
Andreas Metzler
2024-06-23 12:40:03 UTC
Permalink
Control: tags -1 patch
Post by Andreas Tille
Control: tags -1 help
Hi Andreas,
strange, it has build for me.
Very strange, perhaps you did not build against the libgcrypt package in
experimental.
Post by Andreas Tille
Control: reopen 1071860
...
FATAL: libgcrypt-config not found (LIBGCRYPT_CONFIG_SCRIPT-NOTFOUND)
[...]
I admit I currently have no time to track this down. It might make
sense to upgrade to latest upstream which might have been adapted to
work without libgcrypt-config. Tagging the bug help since I have no
capacity to work on this.
Fair enough.

The respective part of the CMake setup is unchanged in 7.1-003.
Attached patch works for me.

Upstream's build system is rather strange. - It requires libgcrypt itself
to be in the standard search but allows the headers to be hidden away:

8X----------------
# Iterate over the list of GPG related libraries
foreach(gpglib gpg-error gpgme gcrypt config)
# For each library, we need a new CMake variable, hence GPGLIB_${gpglib}
find_library(GPGLIB_${gpglib} NAME ${gpglib} PATHS ${CMAKE_LIBRARY_PATH})
# Append the found library to the list
set(GPG_LIBRARIES ${GPG_LIBRARIES} ${GPGLIB_${gpglib}})
endforeach()
[...]
# Locate libgcrypt's header files (assumption: all others headers are found in the same location)
find_program(LIBGCRYPT_CONFIG_SCRIPT NAMES libgcrypt-config)
if (LIBGCRYPT_CONFIG_SCRIPT MATCHES ".+-NOTFOUND")
message(FATAL_ERROR "FATAL: libgcrypt-config not found (${LIBGCRYPT_CONFIG_SCRIPT})")
else()
[...]
8X----------------

A Debian specific patch could simply drop the whole block
find_program(LIBGCRYPT_CONFIG_SCRIPT NAMES libgcrypt-config)
if (LIBGCRYPT_CONFIG_SCRIPT MATCHES ".+-NOTFOUND")
[...]
endif()

I will give it a litte bit of time to check whether somebody else from
-med picks this up and will NMU otherwise.

cu Andreas
--
`What a good friend you are to him, Dr. Maturin. His other friends are
so grateful to you.'
`I sew his ears on from time to time, sure'
Andreas Metzler
2024-06-29 14:00:01 UTC
Permalink
Control: tags -1 pending

On 2024-06-23 Andreas Metzler <***@bebt.de> wrote:
[...]
Post by Andreas Metzler
I will give it a litte bit of time to check whether somebody else from
-med picks this up and will NMU otherwise.
Hello,

I have now uploaded a NMU to delayed/7-days using the attached patch. I
have gone for the mininal change, dropping the respective code instead
of switching to pkgconf. It simpler, does not make a difference on
Debian systems and the whole thing does not make sense to me.

cu Andreas
Andreas Tille
2024-06-30 20:00:01 UTC
Permalink
Hi Andreas,
Post by Andreas Metzler
I have now uploaded a NMU to delayed/7-days using the attached patch. I
have gone for the mininal change, dropping the respective code instead
of switching to pkgconf. It simpler, does not make a difference on
Debian systems and the whole thing does not make sense to me.
I've just pushed your changes to Git. Feel free to use 0-day NMUs
in future.

Kind regards
Andreas.
--
https://fam-tille.de
Loading...