Discussion:
Bug#1077423: fortunes-es: FTBFS: rot.c:23:5: error: implicit declaration of function ‘exit’ [-Wimplicit-function-declaration]
Add Reply
Lucas Nussbaum
2024-07-29 06:00:10 UTC
Reply
Permalink
Source: fortunes-es
Version: 1.36
Severity: serious
Justification: FTBFS
Tags: trixie sid ftbfs
User: ***@debian.org
Usertags: ftbfs-20240728 ftbfs-trixie

Hi,

During a rebuild of all packages in sid, your package failed to build
on amd64.
gcc -O2 -DFORTDIR="\"/usr/share/games/fortunes\"" -DOFFDIR="\"/usr/share/games/fortunes/off\"" -DLOCFORTDIR="\"/usr/local/share/games/fortunes\"" -DLOCOFFDIR="\"/usr/local/share/games/fortunes/off\"" -Wall -fomit-frame-pointer -pipe -fsigned-char -Wdate-time -D_FORTIFY_SOURCE=2 -c -o rot.o rot.c
rot.c:23:5: error: implicit declaration of function ‘exit’ [-Wimplicit-function-declaration]
23 | exit(0);
| ^~~~
rot.c:8:1: note: include ‘<stdlib.h>’ or provide a declaration of ‘exit’
7 | #include <ctype.h>
+++ |+#include <stdlib.h>
8 |
rot.c:23:5: warning: incompatible implicit declaration of built-in function ‘exit’ [-Wbuiltin-declaration-mismatch]
23 | exit(0);
| ^~~~
rot.c:23:5: note: include ‘<stdlib.h>’ or provide a declaration of ‘exit’
make[2]: *** [<builtin>: rot.o] Error 1
The full build log is available from:
http://qa-logs.debian.net/2024/07/28/fortunes-es_1.36_unstable.log

All bugs filed during this archive rebuild are listed at:
https://bugs.debian.org/cgi-bin/pkgreport.cgi?tag=ftbfs-20240728;users=***@debian.org
or:
https://udd.debian.org/bugs/?release=na&merged=ign&fnewerval=7&flastmodval=7&fusertag=only&fusertagtag=ftbfs-20240728&fusertaguser=***@debian.org&allbugs=1&cseverity=1&ctags=1&caffected=1#results

A list of current common problems and possible solutions is available at
http://wiki.debian.org/qa.debian.org/FTBFS . You're welcome to contribute!

If you reassign this bug to another package, please mark it as 'affects'-ing
this package. See https://www.debian.org/Bugs/server-control#affects

If you fail to reproduce this, please provide a build log and diff it with mine
so that we can identify if something relevant changed in the meantime.
Agustin Martin
2024-09-18 17:50:01 UTC
Reply
Permalink
Control: tags -1 + patch
Post by Lucas Nussbaum
Source: fortunes-es
Version: 1.36
Severity: serious
Justification: FTBFS
Tags: trixie sid ftbfs
Usertags: ftbfs-20240728 ftbfs-trixie
Hi,
During a rebuild of all packages in sid, your package failed to build
on amd64.
gcc -O2 -DFORTDIR="\"/usr/share/games/fortunes\"" -DOFFDIR="\"/usr/share/games/fortunes/off\"" -DLOCFORTDIR="\"/usr/local/share/games/fortunes\"" -DLOCOFFDIR="\"/usr/local/share/games/fortunes/off\"" -Wall -fomit-frame-pointer -pipe -fsigned-char -Wdate-time -D_FORTIFY_SOURCE=2 -c -o rot.o rot.c
rot.c:23:5: error: implicit declaration of function ‘exit’ [-Wimplicit-function-declaration]
23 | exit(0);
| ^~~~
rot.c:8:1: note: include ‘<stdlib.h>’ or provide a declaration of ‘exit’
7 | #include <ctype.h>
+++ |+#include <stdlib.h>
...

Hi, Javi,

Attached patch makes package build here.

Regards,
--
Agustin
Javier Fernandez-Sanguino
2024-10-17 16:30:01 UTC
Reply
Permalink
Hi Agustin,

I'm fine with the NMU upload. Regarding Salsa: I would like to upload a Git
repo with all the history so this package can be comaintained easily. Would
you mind not pushing this to Salsa yet?

Best regards

Javier
Saludos,

Javier
Post by Agustin Martin
Control: tags -1 + patch
Post by Lucas Nussbaum
Source: fortunes-es
Version: 1.36
Severity: serious
Justification: FTBFS
Tags: trixie sid ftbfs
Usertags: ftbfs-20240728 ftbfs-trixie
Hi,
During a rebuild of all packages in sid, your package failed to build
gcc -O2 -DFORTDIR="\"/usr/share/games/fortunes\""
-DOFFDIR="\"/usr/share/games/fortunes/off\""
-DLOCFORTDIR="\"/usr/local/share/games/fortunes\""
-DLOCOFFDIR="\"/usr/local/share/games/fortunes/off\"" -Wall
-fomit-frame-pointer -pipe -fsigned-char -Wdate-time -D_FORTIFY_SOURCE=2
-c -o rot.o rot.c
Post by Agustin Martin
Post by Lucas Nussbaum
rot.c:23:5: error: implicit declaration of function ‘exit’
[-Wimplicit-function-declaration]
Post by Agustin Martin
Post by Lucas Nussbaum
23 | exit(0);
| ^~~~
rot.c:8:1: note: include ‘<stdlib.h>’ or provide a declaration of
‘exit’
Post by Agustin Martin
Post by Lucas Nussbaum
7 | #include <ctype.h>
+++ |+#include <stdlib.h>
...
Hi, Javi,
Attached patch makes package build here.
Hi, Javi,
I am preparing a NMU for this, together with making package look more like
current packages look and fixing some lintian stuff.
This includes a (still empty) salsa git repo for the package.
Attached is git diff -w output.
If you do not object I will NMU shortly.
Regards,
--
Agustin
Agustin Martin
2024-10-17 17:40:01 UTC
Reply
Permalink
Post by Javier Fernandez-Sanguino
Hi Agustin,
I'm fine with the NMU upload. Regarding Salsa: I would like to upload a Git
repo with all the history so this package can be comaintained easily. Would
you mind not pushing this to Salsa yet?
Hi, Javi,

Thanks for the quick reply.

In my personal git repo I have all history I could get from
snapshot.debian.org, but you will surely have this more detailed.

To keep the history clean I will wait until you push your git
repo to salsa and then push my changes on top of it. If you do not expect
this to take too long I will wait for the NMU.

Regards,
--
Agustin
Loading...